docs: standardize documentation distribution#25
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
# Conflicts: # carpincho-wallet/CLAUDE.md
Drop references to the deleted src/wc/handlers.ts (WalletConnect events are now wired via wc/client.ts subscriptions in views/home/useWalletConnectLifecycle.ts), add the new views/home and utils modules to the structure tree, record the Sheet center variant, fix the AddAccount-to-AccountsDialog relocation, and complete the icons.tsx inventory.
Collaborator
There was a problem hiding this comment.
A couple of follow-ups surfaced while reviewing the doc redistribution:
dapp/daml/README.mdnow links to the rootdeploy darsstep (thenpm run deploy-darwrapper) instead of the rawdeploy-dar.shcall. That is the documented monorepo idiom, so no change needed; noting only that the invocation form changed, not just its location.
| npm run app:dev # terminal 2 — dApp on :3012 | ||
| ``` | ||
| The full local stack must be running. Follow the root | ||
| [quick start](../../README.md#quick-start), including the wallet, dApp, and |
Collaborator
There was a problem hiding this comment.
This trim drops the npm run wallet:dev step (Carpincho web UI on :3011). The root quick start's ## wallet section documents only carpincho:build:extension, not wallet:dev, yet the e2e suite drives the web UI at CARPINCHO_URL=http://localhost:3011. Following this link alone won't bring :3011 up. Either keep npm run wallet:dev inline here, or add it to the root README ## wallet section so the link actually covers it.
Collaborator
Author
There was a problem hiding this comment.
@gabitoesmiapodo e2e test run the wallet from the extension. there is an inconsistency in the docs, I'll push a fix.
gabitoesmiapodo
approved these changes
Jun 4, 2026
# Conflicts: # CLAUDE.md
Replace the native window.confirm on the unlock screen with a centered Radix Sheet + DangerConfirm, matching the rest of the app. Reset now wipes every carpincho-namespaced storage key (theme, auto-lock, runtime config) and reloads so all providers re-init from a clean slate, instead of only clearing the vault blob.
…eset Vault reset only cleared the carpincho localStorage prefix, leaving two persistence surfaces behind: WalletConnect sessions/pairings/keychain in its IndexedDB database, and the remembered direct-connected dApp origins in chrome.storage.session. Both now cleared so no stale state or dApp connection history survives into the next wallet. - wipeWalletConnectStorage deletes the WalletConnect IndexedDB database - clearDirectConnectedOrigins removes the connected-origins session key - destroyVault orchestrates all wipes and restores React state as a fallback in case the reload is a no-op - wipeAllPersistedData removes keys defensively so one failure cannot strand the rest
fix(wallet): radix reset-vault dialog and full data wipe on reset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #17
Standardizes the documentation distribution model so README, AGENTS, CLAUDE, and architecture docs each have a clear reader, scope, and placement rule.
Changes
Acceptance criteria
Test plan
Automated tests
git diff --cached --checkgit push --dry-run -u origin feat/docs_organizationran the pre-push TypeScript sweep: carpincho-wallet, dapp/frontend, canton-barebones/wallet-service, canton-connect-kitgit push -u origin feat/docs_organizationreran the same pre-push TypeScript sweep and passedManual verification
Breaking changes
None.
Checklist
Screenshots
None.